Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecurityContext to restore-helper #8491

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

reasonerjt
Copy link
Contributor

This commit adds SecurityContext which complies with "restricted" level per Pod Security Standards

Fixes #8229

Please indicate you've done the following:

@reasonerjt reasonerjt changed the title Add SecurityContext to restore-helper [WIP]:Add SecurityContext to restore-helper Dec 6, 2024
@reasonerjt reasonerjt changed the title [WIP]:Add SecurityContext to restore-helper Add SecurityContext to restore-helper Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.03%. Comparing base (2e5df85) to head (4b7f931).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/restore/actions/pod_volume_restore_action.go 72.72% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8491      +/-   ##
==========================================
+ Coverage   58.96%   59.03%   +0.07%     
==========================================
  Files         368      369       +1     
  Lines       39024    39074      +50     
==========================================
+ Hits        23009    23067      +58     
+ Misses      14552    14545       -7     
+ Partials     1463     1462       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit adds SecurityContext that complies with "restricted" level
per Pod Security Standards to "restore-helper" initContainer.
It ensures the restore won't fail when the cluster enforces PSA.

Signed-off-by: Daniel Jiang <[email protected]>
@kaovilai kaovilai merged commit b588dc9 into vmware-tanzu:main Dec 6, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File system restore cannot work in PSA enabled Kubernetes cluster
3 participants