Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Data Movement Node Selection #8186

Open
MuriloCouceiro opened this issue Sep 4, 2024 · 2 comments
Open

Restore Data Movement Node Selection #8186

MuriloCouceiro opened this issue Sep 4, 2024 · 2 comments

Comments

@MuriloCouceiro
Copy link

MuriloCouceiro commented Sep 4, 2024

Describe the problem/challenge you have
In a hybrid (Windows and Ubuntu) cluster, I need to run Velero's pods on my Ubuntu nodes. I'm using the node-agent-config for the CSI Snapshot backup data movement, however, I cannot restore these backups since node selection is not allowed.
The setup uses an NFS CSI Driver SC with Immediate Volume Binding.

Describe the solution you'd like
Use the node-agent-config Configmap node selector for the restore data movement pods.

Anything else you would like to add:
Slack short discussion

Environment:

  • Velero version (use velero version): 1.14.1
  • Kubernetes version (use kubectl version): v1.26.5
  • Kubernetes installer & version: Helm chart v7.1.5
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt
Copy link
Contributor

The reason we chose not to support node selection in restore, is to cover the "waitForFirstConsumer" storageclasses where we need to wait for the restored pod be scheduled first before restoring the PV.

This can be easily fixed if #8044 is fixed.

@Lyndon-Li
Copy link
Contributor

Restore node-selector feature for data mover restore is a valid requirement, however, it will not be used to solve the hybrid cluster problem.
The hybrid cluster problem will be solved as part of Windows support in 1.16 with some other ways.
Therefore, I will remove the Area/WindowsSupport tag and use this issue to track restore node-selector feature itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants