existingResourcePolicy validation outside CLI

[mateusoliveira43]

What steps did you take and what happened:
Created a restore using kubectl command and set existingResourcePolicy to "batman". Restore succeed without mentioned wrong existingResourcePolicy.

What did you expect to happen:
Warn user that is not a valid existingResourcePolicy and present user with available options.

Validation present in CLI command

velero/pkg/cmd/cli/restore/create.go

Lines 424 to 429 in 270b1de

	func isResourcePolicyValid(resourcePolicy string) bool {
	if resourcePolicy == string(api.PolicyTypeNone) || resourcePolicy == string(api.PolicyTypeUpdate) {
	return true
	}
	return false
	}

Anything else you would like to add:
As previously discussed, we do not want to add enum validation in CRD, as there are plans to add more options to that field in the future #6142

So, its best to add validation through code

Environment:

• Velero version (use velero version): 1.12

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• 👍 for "I would like to see this bug fixed as soon as possible"
• 👎 for "There are more important bugs to focus on right now"

[kaovilai]

👋

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

[kaovilai]

unstale