fix scheduleReconciler log info #6524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
Codecov Report
@@ Coverage Diff @@
## main #6524 +/- ##
==========================================
- Coverage 60.28% 60.25% -0.03%
==========================================
Files 238 238
Lines 25256 25268 +12
==========================================
Hits 15226 15226
- Misses 8976 8988 +12
Partials 1054 1054
|
| @@ -199,11 +199,10 @@ func (c *scheduleReconciler) checkIfBackupInNewOrProgress(schedule *velerov1.Sch | |||
|
|
|||
| for _, backup := range backupList.Items { | |||
| if backup.Status.Phase == velerov1.BackupPhaseNew || backup.Status.Phase == velerov1.BackupPhaseInProgress { | |||
| log.Debugf("Schedule %s/%s still has backups are in InProgress or New state, skip submitting backup to avoid overlap.", schedule.Namespace, schedule.Name) | |||
There was a problem hiding this comment.
NIT should it be "... still has backups that are in InProgress..." or "... still has backups in InProgress..."?
There was a problem hiding this comment.
Thanks for the quick review.
I am not a english speaker.
Your suggestion is make sense to me.
yanggangtony
force-pushed
the
fix-log-scheduler
branch
from
f630403
to
e46e918
Compare
ywk253100
reviewed
Jul 20, 2023
| @@ -199,11 +199,10 @@ func (c *scheduleReconciler) checkIfBackupInNewOrProgress(schedule *velerov1.Sch | |||
|
|
|||
| for _, backup := range backupList.Items { | |||
| if backup.Status.Phase == velerov1.BackupPhaseNew || backup.Status.Phase == velerov1.BackupPhaseInProgress { | |||
| log.Debugf("%s/%s still has backups that are in InProgress...", schedule.Namespace, schedule.Name) | |||
There was a problem hiding this comment.
Change it to in InProgress or New? That's confuse if only contains the InProgress state
There was a problem hiding this comment.
Rebased, Thanks review.
Signed-off-by: yanggang <[email protected]>
yanggangtony
force-pushed
the
fix-log-scheduler
branch
from
e46e918
to
c5af315
Compare
ywk253100
approved these changes
Jul 24, 2023
shubham-pampattiwar
approved these changes
Jul 24, 2023
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
The log info is wrong , we should move it to the above code .
/kind cleanup
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.