-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PVC's selector in backup's PVC action. #6481
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6481 +/- ##
=======================================
Coverage 60.03% 60.04%
=======================================
Files 229 229
Lines 24491 24489 -2
=======================================
Hits 14704 14704
+ Misses 8774 8772 -2
Partials 1013 1013
|
Can we make sure the removal of labelSelector only happens when the restore will be done via dynamic provision? (podvolume, CSI). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the PR to unblock merging it, I'm fine the cosmetic code change be applied afterwards
Signed-off-by: Xun Jiang <[email protected]>
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #6444
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.