-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design for pre-post backup-restore action types #6466
base: main
Are you sure you want to change the base?
Design for pre-post backup-restore action types #6466
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6466 +/- ##
==========================================
- Coverage 60.18% 60.18% -0.01%
==========================================
Files 229 229
Lines 24215 24219 +4
==========================================
+ Hits 14575 14577 +2
- Misses 8632 8634 +2
Partials 1008 1008 |
Note that we already have an approved design for this (submitted via #4083 and currently located at https://github.com/vmware-tanzu/velero/blob/main/design/new-prepost-backuprestore-plugin-hooks.md) I haven't reviewed this PR in detail yet, but was it created with reference to that one? If the prior design was insufficient, maybe it would be clearer to submit a PR that modifies that design rather than creates a complete new one. |
e45652a
to
0392900
Compare
I went through the design. I get the overall objective. Can you also highlight some concrete use cases where users need this. Secondly also look into adding rough Action / Action status structs as part of the design. So we get a better idea of the scope of actions we intend to support. |
|
Signed-off-by: Nutrymaco <[email protected]>
0392900
to
90dd1da
Compare
Please add a summary of your change
Add design doc after discussion in #6417
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.