Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Builder plugin build and documentation #438

Open
pchan opened this issue Jul 29, 2023 · 0 comments
Open

Improve Builder plugin build and documentation #438

pchan opened this issue Jul 29, 2023 · 0 comments
Labels
kind/bug PR/issue related to a bug needs-triage

Comments

@pchan
Copy link

pchan commented Jul 29, 2023

Bug description
The builder plugin usage is confusing and the documentation is not clear.

  1. Why do we have 2 different versions of builder ? tanzu builder and a separate builder plugin. The doc section does not mention this.
  2. The make targets plugin build does not work. It looks like we have to specifically build builder plugin for things to work.

Expected behavior
Clear documentation on why duplicate functionality exists and how to build .

Steps to reproduce the bug / Relevant debug output

make plugin-build-install-local
/Users/prasadc/dev/repo/tanzu/tanzu-cli/t1/bin/builder plugin build
--path ./cmd/plugin
--binary-artifacts /Users/prasadc/dev/repo/tanzu/tanzu-cli/t1/artifacts/plugins
--version test/e2e/framework/v1.0.0-dev
--ldflags "-X 'github.com/vmware-tanzu/tanzu-plugin-runtime/plugin/buildinfo.Date=2023-07-29' -X 'github.com/vmware-tanzu/tanzu-plugin-runtime/plugin/buildinfo.SHA=c51eea05' -X 'github.com/vmware-tanzu/tanzu-plugin-runtime/plugin/buildinfo.Version=test/e2e/framework/v1.0.0-dev'"
--goflags ""
--os-arch darwin_amd64
--match "*"
--plugin-scope-association-file ./cmd/plugin/plugin-scope-association.yaml
bash: line 1: /Users/prasadc/dev/repo/tanzu/tanzu-cli/t1/bin/builder: No such file or directory
make: *** [plugin-build-darwin-amd64] Error 127

Output of tanzu version

./bin/tanzu version
version: test/e2e/framework/v1.0.0-dev
buildDate: 2023-07-29
sha: c51eea0

Environment where the bug was observed (cloud, OS, etc)
Mac (Darwin)

@pchan pchan added kind/bug PR/issue related to a bug needs-triage labels Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug PR/issue related to a bug needs-triage
Projects
None yet
Development

No branches or pull requests

1 participant