Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new K8s version v1.32 #2157

Open
4 of 10 tasks
joshuatcasey opened this issue Dec 11, 2024 · 3 comments
Open
4 of 10 tasks

Add new K8s version v1.32 #2157

joshuatcasey opened this issue Dec 11, 2024 · 3 comments

Comments

@joshuatcasey
Copy link
Member

joshuatcasey commented Dec 11, 2024

Adding a new Kubernetes Version

pinniped's ci branch

  • Update dockerfile-builders pipeline
  • Update pull-requests pipeline
  • Update main pipeline
  • Log in to github as pinniped-ci-bot, then go to this page and change the settings for the new k8s-code-generator-1.* image to be publicly visible

pinniped

The below tasks are implemented in #2160:

  • Bump all golang dependencies (especially the k8s.io dependencies to use the new minor version).
    • Be sure to verify that everything compiles and unit tests pass locally. This is probably a good starting point.
./hack/update-go-mod/update-go-mod.sh
./hack/module.sh unit
./hack/prepare-for-integration-tests.sh
  • Add the new K8s version to hack/lib/kube-versions.txt and run code generation.

General Tasks

  • Consider dropping support for any older versions of Kubernetes
  • Create stories or chores to take advantage of features in the new Kubernetes version
  • Close this issue
@joshuatcasey
Copy link
Member Author

I've added branch jtc/bump-to-k8s-1-32-libs to bump the libs and make accommodating changes. This branch does compile (at e6d3bff27) and unit tests pass (without go test -race). Using go test -race does yield multiple data races that appear to be the same issue as kubernetes/kubernetes#128548, so we may need to wait for v0.32.X libs with a fix.

@cfryanr
Copy link
Member

cfryanr commented Dec 16, 2024

For anyone else looking at this issue, the data race in the Kubernetes code can be easily replicated by cloning this repo, checking out Josh's branch jtc/bump-to-k8s-1-32-libs, and then running go test -race -count 1 ./internal/concierge/impersonator/.... It fails the race detector every time.

@joshuatcasey
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants