Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues with nvfortran #40

Open
gha3mi opened this issue May 8, 2024 · 1 comment
Open

Compatibility issues with nvfortran #40

gha3mi opened this issue May 8, 2024 · 1 comment

Comments

@gha3mi
Copy link
Collaborator

gha3mi commented May 8, 2024

Hi @vmagnin

I've identified the issue with the nvfortran compiler and reported a simple example on the nvidia compiler forum:
https://forums.developer.nvidia.com/t/nvfortran-f-0000-internal-compiler-error-module-new-dtype-dt-nfd/292240

The following changes will resolve the issue and ensure that ForColormap is compatible with nvfortran. I hope that the issue will be resolved soon, but until then, it would be great to consider these changes:


character(*), dimension(*), public, parameter :: colormaps_list = &

to

character(*), dimension(6+222+4), public, parameter :: colormaps_list = &


character(*), dimension(*), parameter, public :: miscellaneous_colormaps_list = &

to

character(*), dimension(6), parameter, public :: miscellaneous_colormaps_list = &


character(*), dimension(*), parameter, public :: miscellaneous_colormaps_list = &

to

character(*), dimension(222), parameter, public :: scientific_colour_maps_list = &


character(*), dimension(*), parameter, public :: matplotlib_colormaps_list = &

to

character(*), dimension(4), parameter, public :: matplotlib_colormaps_list = &

@vmagnin
Copy link
Owner

vmagnin commented May 9, 2024

Thanks @gha3mi, I have committed those fixes: b7e6154
We can let the issue open to revert these changes latter.
The 2nd and 4th are not really annoying, but the two with 222 are more annoying if we add more colourmaps and forget to update these numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants