Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: HiDiffusion does not work completely with Prompts From File #3420

Open
2 tasks done
teamolhuang opened this issue Sep 11, 2024 · 1 comment
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@teamolhuang
Copy link

Issue Description

Using a prompt that has been tested to be outputting good results,
keep the basic settings default - 512x512, 20steps - , while using Prompt From File to generate with different configs:

--width 1920 --height 1080 --steps 28 --sampler_name "euler a" --cfg_scale 7
--width 1080 --height 1920 --steps 28 --sampler_name "euler a" --cfg_scale 7
--width 1920 --height 1080 --steps 25 --sampler_name "euler a" --cfg_scale 4
--width 1080 --height 1920 --steps 25 --sampler_name "euler a" --cfg_scale 4
--width 1920 --height 1080 --steps 22 --sampler_name "euler a" --cfg_scale 3
--width 1080 --height 1920 --steps 22 --sampler_name "euler a" --cfg_scale 3

This results in generally bad anatomy, mostly very long human body/waist or double cleavages. Fixing the width/height settings to be either 1920x1080 or 1080x1920 fixes that. Generated ~60 images and at least 90% of them shows such symptom.

This doesn't only apply to resolutions, from what I observe, HiDifussion applies until a certain count of steps, but it seems to read the steps from basic settings as divisor.

This results in different resolutions and different step counts through Prompt From File, combined with HiDiffusion, might cause unexpected results.

Version Platform Description

Windows 11
AMD 6900XT + ZLUDA
sd-next 2024-07-01 081c19f
Google Chrome

Relevant log output

No response

Backend

Diffusers

UI

ModernUI

Branch

Master

Model

StableDiffusion XL

Acknowledgements

  • I have read the above and searched for existing issues
  • I confirm that this is classified correctly and its not an extension issue
@vladmandic vladmandic changed the title [Issue]: HiDiffusion does not work completely with Prompts From File [Feature]: HiDiffusion does not work completely with Prompts From File Sep 11, 2024
@vladmandic vladmandic added the enhancement New feature or request label Sep 11, 2024
@vladmandic
Copy link
Owner

combining multiple advanced options, especially with scripts is considered a feature.
in this case, script sets resolution after hidiffusion has already been initialized.
prompts-from-file script has not been updated in a long time, its one of the few original scripts.
contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants