Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Control: allow matching destination aspect ratio for overrides without an input image #3395

Open
lbeltrame opened this issue Sep 1, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lbeltrame
Copy link
Contributor

Feature description

Currently the code works when an input image is set. However, when doing text to image, there's no input image set, only overrides (unless the first image is used as input image), and thus the control images will get stretched to match the destination resolution.

In case no input image is set, resizing should be done matching on the destination resolution (this is what the old ControlNet extension did).

Version Platform Description

No response

@lbeltrame lbeltrame added the enhancement New feature or request label Sep 1, 2024
@vladmandic
Copy link
Owner

i understand the problem, but not sure how to address it.

if there is input image, any unit can use that information to resize override image (that was recently added).
but its not the other way around - core loop cannot resize itself based on unit output.
also note that there can be any number of units, each having different override and working at different resolutions - what should core do then? resize to first unit and ignore the rest?

keeping this open for the moment.

@lbeltrame
Copy link
Contributor Author

Good point. I think the original CN extension was kind of messy in that regard (I have no idea how it did things internally) because you could set it differently for any unit (and that generated eldritch abominations in case the various units did not match).
Note that this AFAICS only occurs if you don't preprocess (I didn't test, though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants