optimizeDeps and deps that requires Vite plugins' transform

[Menci]

I'm the author of vite-plugin-wasm. This plugin aims at adding WebAssembly ESM integration to Vite.

Most users of WebAssembly ESM integration are users wasm-pack-generated NPM packages. So this plugin often does process the code in node_modules. It works fine in Vite's Rollup build but breaks with optimizeDeps.

With optimizeDeps turned on (by default it's turned on in dev server), The code in node_modules are processed by ESBuild first, passing import "filename.wasm" to ESBuild, which is not supported and resulting in an error. Currently the solution is adding the wasm-pack-generated package to optimizeDeps.exclude.

It is a common or very rare situation that a NPM package must be processed by a Vite plugin to be imported successfully? Will there be a better solution without manually adding packages to optimizeDeps.exclude, e.g. some API to let the plugin to tell ESBuild to skip processing some type of files like \.wasm$?

[sapphi-red]

There was a bug. Scanner and optimizer shouldn't read wasm files but it was reading them: #9257

BTW I'm having an error even with the PR above. (Uncaught ReferenceError: Cannot access 'memory' before initialization)
https://stackblitz.com/edit/vitejs-vite-slmmpk

[Menci]

It's just the package's bug (caused by rustwasm/wasm-bindgen#2961). The JS glue code is accessing WASM's memory export before it's initialized.

(Adding a console.log(wasm) just after importing WASM in rapier_wasm2d.js)

$ node --experimental-wasm-modules
Welcome to Node.js v17.6.0.
Type ".help" for more information.
> await import("@dimforge/rapier2d/rapier_wasm2d.js")
(node:20213) ExperimentalWarning: Importing WebAssembly modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
[Module: null prototype] {
  ...
  __wbindgen_malloc: <uninitialized>,
  memory: <uninitialized>,
  rawbroadphase_new: <uninitialized>,
  rawccdsolver_new: <uninitialized>,
  ...
}
Uncaught ReferenceError: memory is not defined
    at file:///Users/Menci/tla/node_modules/@dimforge/rapier2d/rapier_wasm2d_bg.js:4274:46
    at ModuleJob.run (node:internal/modules/esm/module_job:197:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:341:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async REPL1:1:24
>

[sapphi-red]

I see. Thanks.