Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useDevicePixels seems to be interpreted badly (v9.0) #2144

Open
xinaesthete opened this issue Jul 30, 2024 · 2 comments
Open

useDevicePixels seems to be interpreted badly (v9.0) #2144

xinaesthete opened this issue Jul 30, 2024 · 2 comments
Labels
Milestone

Comments

@xinaesthete
Copy link
Collaborator

It seems that with a window.devicePixelRatio === 2, luma renders into the lower-left corner of the canvas unless you explicitly set for example WebGLDevice.create({ useDevicePixels: false });.

I haven't tested with other kinds of devices etc.

@ibgreen
Copy link
Collaborator

ibgreen commented Jul 30, 2024

@xinaesthete thanks for reporting.

Is this on master or 9.0? There has been a fix related to rendering in lower-left corner on master. Probably one of the below PRs, might be possible to backport and put up a PR on 9.0-release.

ddb6ab0 fix(webgl): Apply default viewport sizes (#2116)
cc973d8 chore: Remove spurios device.getSize() (#2120)

@xinaesthete
Copy link
Collaborator Author

This is on 9.0, I meant to mention that.

@ibgreen ibgreen changed the title useDevicePixels seems to be interpreted badly useDevicePixels seems to be interpreted badly (v9.0) Aug 21, 2024
@ibgreen ibgreen added this to the v9.1 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants