-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn when unimplemented podspec constructs are seen #29
Comments
Just record an Event for the Pod. That's the Kubernetes way! VK also does it.Running |
Now that we have a k8s client, this should be easier, the only way VK allowed for events was to return an error; we may still want to return an error, alternatively we need to be very clear what returns an error and what returns an event |
Return errors to whom? VK? |
Yes
…On Mon, 28 Dec 2020, 11:45 Pires, ***@***.***> wrote:
Return errors to whom? VK?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWIW2RXBLWUEIM7V3OKZTSXBOVLANCNFSM4VGXSTAA>
.
|
In #65, I'm introducing an event recorder that is passed onto the VK's Pod controller. If desired, we can have the same or similar event recorder in our provider to write events for the Pod being processed. |
Something like that makes sense. however it requires for us to know when we
see something we can't do or haven't implemented... Which is a lot of work
…On Wed, 20 Jan 2021, 21:29 Pires, ***@***.***> wrote:
In #65 <#65>, I'm
introducing an event recorder that is passed onto the VK's Pod controller.
If desired, we can have the same or similar event recorder in our provider
to write events for the Pod being processed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWIW4UVF4LGPR744WLGX3S244JVANCNFSM4VGXSTAA>
.
|
Maybe not, maybe not. |
Right now there is no good way (except reading the source of pod.go) to know if a specific construct in a podspec is implemented or not. It would be good to log/alert/fail if we see such a construct. This would also make it clear what things are still "to be implemented"
The text was updated successfully, but these errors were encountered: