Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when unimplemented podspec constructs are seen #29

Open
miekg opened this issue Dec 23, 2020 · 7 comments
Open

warn when unimplemented podspec constructs are seen #29

miekg opened this issue Dec 23, 2020 · 7 comments

Comments

@miekg
Copy link
Collaborator

miekg commented Dec 23, 2020

Right now there is no good way (except reading the source of pod.go) to know if a specific construct in a podspec is implemented or not. It would be good to log/alert/fail if we see such a construct. This would also make it clear what things are still "to be implemented"

@pires
Copy link
Member

pires commented Dec 27, 2020

Just record an Event for the Pod. That's the Kubernetes way! VK also does it.Running kubectl describe pod <pod name> will show the events.

@miekg
Copy link
Collaborator Author

miekg commented Dec 28, 2020

Now that we have a k8s client, this should be easier, the only way VK allowed for events was to return an error; we may still want to return an error, alternatively we need to be very clear what returns an error and what returns an event

@pires
Copy link
Member

pires commented Dec 28, 2020

Return errors to whom? VK?

@miekg
Copy link
Collaborator Author

miekg commented Dec 28, 2020 via email

@pires
Copy link
Member

pires commented Jan 20, 2021

In #65, I'm introducing an event recorder that is passed onto the VK's Pod controller. If desired, we can have the same or similar event recorder in our provider to write events for the Pod being processed.

@miekg
Copy link
Collaborator Author

miekg commented Jan 20, 2021 via email

@pires
Copy link
Member

pires commented Jan 20, 2021

Maybe not, maybe not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants