Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transitionTo doesn't support excluding the route name #74

Open
amk221 opened this issue Oct 20, 2022 · 9 comments
Open

transitionTo doesn't support excluding the route name #74

amk221 opened this issue Oct 20, 2022 · 9 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@amk221
Copy link

amk221 commented Oct 20, 2022

For example:

this.router.transitionTo({ queryParams: { page: 1 }});

Results in:

The route my-engine.[object Object] was not found
@amk221
Copy link
Author

amk221 commented Oct 20, 2022

I just found a duplicate in Closed Issues

@amk221
Copy link
Author

amk221 commented Oct 20, 2022

Here is a reproduction as requested

amk221/-ember-engine-router-qps@97bc7e4

@amk221
Copy link
Author

amk221 commented Jan 10, 2024

I think this is still an issue, can anyone confirm?

@villander
Copy link
Owner

@aklkv do you have this issue in your app?

@aklkv
Copy link
Contributor

aklkv commented Feb 17, 2024

I will confirm further in my app, later today

@aklkv
Copy link
Contributor

aklkv commented Feb 17, 2024

@villander I noticed this issues while working on refresh method but we have decided not address it as part of that PR, the solution is similar what I did here. I can take a stub at solving it. It might a little bit more involved and refresh method might have same issue, we need something like this gotta love positional params

@villander villander added bug Something isn't working help wanted Extra attention is needed labels May 4, 2024
@villander
Copy link
Owner

@aklkv any chance to tackle it and open a PR?

@aklkv
Copy link
Contributor

aklkv commented Nov 12, 2024

I could but it would have to be in a few weeks

@villander
Copy link
Owner

@aklkv no problem, in your time ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants