Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: npm run build should produce ES5 code to properly support old MFDs #450

Open
mman opened this issue Oct 7, 2024 · 0 comments · May be fixed by #452
Open

Bug: npm run build should produce ES5 code to properly support old MFDs #450

mman opened this issue Oct 7, 2024 · 0 comments · May be fixed by #452
Labels
bug Something isn't working

Comments

@mman
Copy link
Collaborator

mman commented Oct 7, 2024

... continuation of https://github.com/victronenergy/victron-mfd-modules/issues/14.

Currently the code emitted to dist/ is a strange mix of anything that comes in that luckily works on the MFDs but only until a point where a modern dependency comes in like MQTT 5.

Make sure we really produce ES5.
@mman mman added the bug Something isn't working label Oct 7, 2024
@mman mman linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mqtt 5 victronenergy/venus-html5-app
1 participant
@mman