Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tank gauges to table #367

Open
fwaalkens opened this issue Mar 6, 2024 · 0 comments
Open

Convert tank gauges to table #367

fwaalkens opened this issue Mar 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fwaalkens
Copy link
Contributor

fwaalkens commented Mar 6, 2024

Problem:
Tank names vary in length, because of this we hack around it by truncating/giving it a fixed width for the first column, this solution is suboptimal for the vast amount of mfd resolutions.

image

Solution:
Put the tanks in a table, with this solution the first column width will be determined by the longest tank name.

image

Additional challenges:
These components are wrapped by a paginator component that expects multiple children (the tanks). The paginator breaks when wrapping the children with a table component.

See experiment in this branch: https://github.com/victronenergy/venus-html5-app/tree/temp/refactor-tank-gauges-to-table

@fwaalkens fwaalkens added the bug Something isn't working label Mar 6, 2024
@martinbosma martinbosma added enhancement New feature or request and removed bug Something isn't working labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants