Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genset page: service & runtime metrics #1409

Closed
4 tasks done
ReinvdZee opened this issue Aug 13, 2024 · 4 comments · Fixed by #1448
Closed
4 tasks done

Genset page: service & runtime metrics #1409

ReinvdZee opened this issue Aug 13, 2024 · 4 comments · Fixed by #1448

Comments

@ReinvdZee
Copy link
Contributor

ReinvdZee commented Aug 13, 2024

Some work is done related to run time and service metrics (see issue). Following changes apply to the connected genset menu, as well as the relay-controlled (generator start/stop) menu, unless otherwise noted.

  • Remove “Operating time” of connected gensets from the “Engine” page.
  • Move the “Run time and service” from settings to the top-level and add some items. This menu should contain:
    a. Total run time. This field is synchronized with /Engine/OperatingHours (if valid). If the path does not exist (relay controlled generator) or is invalid (unsupported by connected genset), the total run time entry should be modifiable like it is now.
    b. Daily run time counters (submenu)
    c. Daily run time counters reset button
    d. Time to next test run (if enabled)
    e. Service timer (if nonzero service interval)
    f. Service interval setting
    g. Service timer reset button
  • Rename “Run time” to “Current run time” and show it on the top-level if the generator is running, warming up or cooling down. (/State equal to 1, 2 or 3).
  • Reorder the menu structure of the generator start/stop (relay) to be the same as that of the genset menu.

The new run time & service menu:
image
image

@ReinvdZee
Copy link
Contributor Author

The new "Run time and service" menu looks like this:
image

I also moved the "Accumulated running time since last test run" entry here. It is only visible when test runs are enabled and the user has access level service.

@mpvader
Copy link
Contributor

mpvader commented Sep 5, 2024

@ReinvdZee what needs to happen to get this merged?

@mpvader
Copy link
Contributor

mpvader commented Sep 5, 2024

discussed today in the meeting @blammit will look into this herself, with help from Philipp, if she gets to this one before Rein is back.

blammit pushed a commit that referenced this issue Sep 9, 2024
- Remove Operating time from the Engine page.
- Sync total run time with genset `/Engine/OperatingHours` (dbus_generator)
- Add 'Run time and service' menu at top level
- Remove Total run time from top level since its part of the run time and service menu.
- Change 'Run time' to 'Current run time' on top-level
- Only show 'Current run time' when generator is running, warming up or cooling down.
- Move service interval setting to run time and service menu
- Reordered menu items of generator start stop (relay).
- Changed toast message when disabling the service interval timer.

Fixes #1409
@blammit blammit linked a pull request Sep 9, 2024 that will close this issue
@blammit
Copy link
Contributor

blammit commented Sep 9, 2024

@ReinvdZee I've made a PR at #1448 using the patch you sent me earlier. I added some checks for empty UIDs, as we discussed previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants