Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Apply Joystick improvements from upstream qmk #384

Closed
3 of 4 tasks
9R opened this issue Mar 1, 2023 · 3 comments
Closed
3 of 4 tasks

[Feature Request] Apply Joystick improvements from upstream qmk #384

9R opened this issue Mar 1, 2023 · 3 comments

Comments

@9R
Copy link
Contributor

9R commented Mar 1, 2023

Feature Request Type

  • Core functionality
  • Improve hardware support: Joystick
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

QMK merged some improvements for the joystick implementation in January: qmk/qmk_firmware#19052

This changed some variables which makes it harder to maintain configurations for qmk and qmk-vial.

Because of these changes following current QMK documentation on how to implement joysticks does not work with Vial any more and will result in failed builds and there is no Vial-specific documentation describing the current implementation in vial. This currently makes it harder to port new devices with Joysticks or analog inputs to Vial.

Here is a summary of improvements copied from the original pull requests:

  • Improved documentation, added API reference
  • Renamed JOYSTICK_AXES_COUNT/JOYSTICK_AXES_RESOLUTION to singular AXIS to align with JOYSTICK_BUTTON_COUNT
  • Replaced enum joystick_status with simple dirty flag in joystick_t
  • Added V-USB support
  • Added shared EP support for LUFA/ChibiOS

Is it possible to merge these changes in Vial?

@Cujo26
Copy link
Contributor

Cujo26 commented Mar 20, 2023

Vial periodically merges changes from upstream, so new features should get implemented, just on a bit of a delay compared to the main project.

@lesshonor
Copy link
Contributor

If this is very important to you, you can help test the (current as of June 6) beta merge branch on your keyboard's hardware, which incorporates these updates and many more: https://github.com/vial-kb/vial-qmk/tree/merge-2023-06-03

You will need a new version of the GUI to work with any firmware from this branch: https://github.com/vial-kb/vial-gui/actions/runs/5108218697

@9R
Copy link
Contributor Author

9R commented Oct 5, 2024

Sorry for the long response time on my end. I have tested against current vial and the issue is not present any more.

I have also created a PR for the keyboard that is using this feature.

@9R 9R closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants