Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DPIUtil::get(Native)DeviceZoom() calls for all the snippets and tests #195

Open
ShahzaibIbrahim opened this issue Jan 20, 2025 · 0 comments
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@ShahzaibIbrahim
Copy link

ShahzaibIbrahim commented Jan 20, 2025

Following are the places where getDeviceZoom is called. We need to figure out whether and how to replace these calls. As per my findings, the tests always use 100 as the device zoom.

org.eclipse.swt.graphics.GCWin32Tests.drawnElementsShouldScaleUpToTheRightZoomLevel()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_GC.executeWithNonDefaultDeviceZoom(Runnable)
org.eclipse.swt.snippets.Snippet373.main(String[])
org.eclipse.swt.tests.manual.Issue0445_HiDPISmoothScaling.main(String[])
org.eclipse.swt.widgets.PatternWin32ManualTest.main(String[])
org.eclipse.swt.tests.junit.DPIUtilTests.scaleDownFloatArray()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleDownInteger()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleDownPoint()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleDownRectangle()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleUpFloat()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleUpIntArray()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleUpInteger()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleUpPoint()
org.eclipse.swt.tests.junit.DPIUtilTests.scaleUpRectangle()
org.eclipse.swt.tests.junit.DPIUtilTests.setup()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Display.test_Constructor()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_GC.test_copyAreaIIIIII()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_GC.test_copyAreaLorg_eclipse_swt_graphics_ImageII()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image.test_getImageData_100()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image.test_getImageData_125()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image.test_getImageData_150()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image.test_getImageData_200()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image.test_updateWidthHeightAfterDPIChange()
org.eclipse.swt.widgets.WidgetWin32Tests.testButtonFontAfterZooming()
org.eclipse.swt.widgets.WidgetWin32Tests.testButtonPointsAfterZooming()
org.eclipse.swt.widgets.WidgetWin32Tests.testCaretInStyledTextAfterZooming()
org.eclipse.swt.widgets.WidgetWin32Tests.testCoolItemAfterZooming()
org.eclipse.swt.widgets.ControlWin32Tests.testDoNotScaleFontCorrectlyInNoAutoScaleSzenario()
org.eclipse.swt.widgets.WidgetWin32Tests.testExpandItemAfterZooming()
org.eclipse.swt.widgets.WidgetWin32Tests.testImagePixelsWithDoubleZoomLevel()
org.eclipse.swt.graphics.ImageWin32Tests.testImageShouldHaveDimesionAsPerZoomLevel()
org.eclipse.swt.graphics.RegionWin32Tests.testRegionMustBeScaledOnHandleOfScaledZoomLevel()
org.eclipse.swt.graphics.TransformWin32Tests.testScaledTrasformMustHaveScaledValues()
org.eclipse.swt.widgets.ControlWin32Tests.testScaleFontCorrectlyInAutoScaleSzenario()
org.eclipse.swt.graphics.TransformWin32Tests.testShouldHaveDifferentHandlesAtDifferentZoomLevels()
org.eclipse.swt.widgets.WidgetWin32Tests.testTabFolderSizeAfterZooming()
org.eclipse.swt.widgets.WidgetWin32Tests.testTableAfterZooming()
org.eclipse.swt.widgets.WidgetWin32Tests.testTreeAfterZooming()
org.eclipse.swt.widgets.WidgetWin32Tests.testWidgetZoomShouldChangeOnZoomLevelChange()
`
@ShahzaibIbrahim ShahzaibIbrahim added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature labels Jan 20, 2025
@ShahzaibIbrahim ShahzaibIbrahim moved this to 🔖 Ready: Atomic in HiDPI Jan 20, 2025
@HeikoKlare HeikoKlare marked this as a duplicate of #192 Jan 20, 2025
@HeikoKlare HeikoKlare added this to the 4.36 M1 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: 🔖 Ready: Atomic
Development

No branches or pull requests

2 participants