Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including slash #211

Open
Schtil opened this issue Apr 5, 2023 · 5 comments
Open

Including slash #211

Schtil opened this issue Apr 5, 2023 · 5 comments

Comments

@Schtil
Copy link

Schtil commented Apr 5, 2023

Hi!
Thanks for this repository.
Are there any plans to add slash to this collection?

https://varnish-cache.org/#two-new-storage-engines-for-varnish-cache

@gquintard
Copy link
Collaborator

Hi!

Technically I'd say "possibly not", politically, I'd say "yes, but maybe-no, I don't really have an idea and it's not my call let me tag @hermunn"

I don't think slash belongs here yet. It's not small, and it's not old/tried enough to be trusted to the same level as the other vmods here.
However I understand the need for disk storage in the open-source version, and I believe we can make slash and fellow more accessible by packaging them. Notably, I can

  • package them for arch and alpine
  • at least make them easy to install on the docker image, and later make them part of it
  • reach out to the various vmod packagers I can track for inclusion in debian, fedora and freeBSD

@nigoroll
Copy link
Contributor

nigoroll commented Apr 5, 2023

@gquintard nice, I would very much appreciate those packaging efforts. Be assured of my support.

@gquintard
Copy link
Collaborator

gquintard commented Apr 6, 2023

@nigoroll , while I have you here: I believe that to build slash I need the Varnish source, and possibly have some headers built too (at least it's the case for pesi I believe). Is there a better way than to ./autogen.sh && ./configure && make (like, is there a secret make target to build just the generated headers)?

@nigoroll
Copy link
Contributor

nigoroll commented Apr 7, 2023

@gquintard how much off topic can we take this ticket? ;)

The SLASH/ INSTALL.rst and pESI INSTALL.rst should answer your questions.

But in short, both need the source because we need access to data structures not in the API (so both VMODs (implicitly) use $ABI strict). SLASH/ was spun off with vcdk and has bootstrap, while pESI needs ./autogen.sh && ./configure.

Generated files are just the usual ones required for VMOD binding and VSCs. In principle, we could make tehm part of the distribution (right now they are defined as nodist_ in src/Makefile), but I am not confident that this is a good idea, because I think this would increase the likelyhood of people compiling code incompatible with their varnish-cache source.

@gquintard
Copy link
Collaborator

@gquintard how much off topic can we take this ticket? ;)

you are among friends, this is a safe space :-)

Thanks for the info, mainly I was after: "is there a intermediate make target that wouldn't force me to build all the binaries" as it's the heavies part of the process, and it's pretty redundant as I usually already have the binaries installed already, so having to go through the compilation just to get extra headers that weren't installed is a bit annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants