Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for additional options when connecting to a database. #548

Closed
pygeek opened this issue Jul 11, 2024 · 0 comments
Closed

Add support for additional options when connecting to a database. #548

pygeek opened this issue Jul 11, 2024 · 0 comments

Comments

@pygeek
Copy link
Contributor

pygeek commented Jul 11, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Unable to pass parameters to databases via connect_to_<database> (ie: psycopg2->postgres connection_timeout)

Describe the solution you'd like
Add support for all parameters a database may support.

Describe alternatives you've considered
None that I can think of.

Related
#541
#542
#475

https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS
pygeek added a commit to pygeek/vanna that referenced this issue Jul 11, 2024
@pygeek
vanna-ai#548: Added support for additional db connect options.
2a40e9d
pygeek added a commit to pygeek/vanna that referenced this issue Jul 11, 2024
@pygeek
vanna-ai#548: Added additional sqlite args.
36ddc23
@pygeek pygeek mentioned this issue Jul 11, 2024
Merged
zainhoda added a commit that referenced this issue Jul 25, 2024
@zainhoda
Merge pull request #549 from pygeek/feat-db-opts
64164cf 
#548: Added support for additional db connect options.
@pygeek pygeek closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pygeek