You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After updating to Composer 2.0.11 (from 1.10.20) and using vaimo/composer-patches 4.22.4, a patch list that previously applied without issue now crashes immediately as the patch application process begins with the following error:
PHP Fatal error: Uncaught Error: Call to a member function then() on null in /var/www/html/vendor/vaimo/composer-patches/src/Compatibility/Executor.php:88
Stack trace:
#0 /var/www/html/vendor/vaimo/composer-patches/src/Managers/RepositoryManager.php(72): Vaimo\ComposerPatches\Compatibility\Executor->processReinstallOperation(Object(Composer\Repository\InstalledFilesystemRepository), Object(Composer\Installer\InstallationManager), Object(Vaimo\ComposerPatches\Composer\ResetOperation)) #1 /var/www/html/vendor/vaimo/composer-patches/src/Console/Silencer.php(37): Vaimo\ComposerPatches\Managers\RepositoryManager->Vaimo\ComposerPatches\Managers{closure}() #2 /var/www/html/vendor/vaimo/composer-patches/src/Managers/RepositoryManager.php(73): Vaimo\ComposerPatches\Console\Silencer->applyToCallback(Object(Closure)) #3 /var/www/html/vendor/vaimo/composer-patches/src/Repository/PatchesApplier.php(198): Vaimo\ComposerPatches\Managers\RepositoryManager->resetPackage(Object(Composer\Repository\InstalledFilesystemRepository), Object(Compos in /var/www/html/vendor/vaimo/composer-patches/src/Compatibility/Executor.php on line 88
Pre-requisites
Update Composer to 2.0.11
vaimo/composer-patches 4.22.4
Patches pulled from a web server with HTTP Basic Auth
Credentials for the web server set up in auth.json
To Reproduce
Steps to reproduce the behavior:
Delete the vendor directory created by Composer 1.x
Run composer update
Expected
The patches are successfully download from the web server and applied to the codebase
Actual
PHP fatal error when downloading the patch files.
Just so it doesn't get called out, the example from the patch list is for older Magento versions, but this was attempted on Magento 2.4.2 (for which there are a few applicable patches in the complete list).
This looks worrisome! So it's the downloader not returning a promise in certain cases :/ Will try to repeat with the same setup and will get back to you with a fix ASAP.
Thank you for the report and apologies for the inconvenience.
After updating to Composer 2.0.11 (from 1.10.20) and using vaimo/composer-patches 4.22.4, a patch list that previously applied without issue now crashes immediately as the patch application process begins with the following error:
Pre-requisites
To Reproduce
Steps to reproduce the behavior:
composer update
Expected
The patches are successfully download from the web server and applied to the codebase
Actual
PHP fatal error when downloading the patch files.
Notes
The patch list is in the following format:
The text was updated successfully, but these errors were encountered: