Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash For iPhone 6s #90

Open
look416 opened this issue Aug 9, 2018 · 0 comments
Open

Crash For iPhone 6s #90

look416 opened this issue Aug 9, 2018 · 0 comments

Comments

@look416
Copy link

look416 commented Aug 9, 2018

iPhone 6s will crash when trying to load the documents under vertical orientation.

Using storyboard method VC, set the flow direction for the collection view to be vertical.

under UICollectionViewDelegateFlowLayout->section vertical
the contentViewSize.width is 464.000000006 and the bounds.width is 464
By doing comparison between two value which equates to false and hence will go to fatal error.

You can refer to PDFSinglePageViewer.swift -> Line 172

Surprisingly, this only happens to iPhone 6s, it works will with my iPhone X and iPhone 4.

My suggestion would be by flooring the value for contextViewSize before comparing the value with bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant