Support multiple config file types #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
========================================
+ Coverage 0.00% 4.03% +4.03%
========================================
Files 1 5 +4
Lines 67 421 +354
========================================
+ Hits 0 17 +17
- Misses 67 401 +334
- Partials 0 3 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rappizs
force-pushed
the
config-type-support
branch
from
c67555b to
9b1e889
Compare
Signed-off-by: Zsolt Rappi <[email protected]>
rappizs
force-pushed
the
config-type-support
branch
from
9b1e889 to
6315735
Compare
rappizs
changed the title
rappizs
changed the title
rappizs
force-pushed
the
config-type-support
branch
3 times, most recently
from
8109cca to
ae10b6e
Compare
rappizs
force-pushed
the
config-type-support
branch
3 times, most recently
from
8a23efb to
3e8e095
Compare
Signed-off-by: Zsolt Rappi <[email protected]>
rappizs
force-pushed
the
config-type-support
branch
from
3e8e095 to
7f95181
Compare
justaugustus
requested changes
Sep 4, 2023
Signed-off-by: Zsolt Rappi <[email protected]>
rappizs
force-pushed
the
config-type-support
branch
from
2d79b89 to
e368b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Dev notes
Why copied the encoding package instead of using Viper's Write methods? Unfortunately those methods have some problems and they are not reliable (A Viper contributor told me not to use them). They will be removed from Viper and after some discussion I decided to reuse their code. They also told me that the encoding package will be a separate project eventually, so as soon as that happens we can replace our encoding package with that.