Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unit and integration tests for Experiments endpoint according to user stories #310

Closed
1 task done
keithmanville opened this issue Oct 27, 2023 · 1 comment
Closed
1 task done

Implement unit and integration tests for Experiments endpoint according to user stories #310

keithmanville opened this issue Oct 27, 2023 · 1 comment
Assignees
@lbarbMITRE
Labels
test Additions or changes to project tests
Milestone
November Milestone

Comments

@keithmanville
Copy link
Collaborator

keithmanville commented Oct 27, 2023 •
edited by jkglasbrenner
Loading

Implement unit and integration tests for the Experiments endpoint according to user stories defined in #284

Follow the integration test pattern from #281

Definition of Done

  • 100% coverage of Experiments endpoints

Dependencies

depends on #284
This was referenced Oct 27, 2023
Closed
Closed
@keithmanville keithmanville added the test Additions or changes to project tests label Nov 7, 2023
@lbarbMITRE lbarbMITRE mentioned this issue Nov 14, 2023
Merged
@keithmanville keithmanville added this to the November Milestone milestone Nov 14, 2023
jkglasbrenner pushed a commit that referenced this issue Nov 30, 2023
@lbarbMITRE @jkglasbrenner
test: add experiment integration tests that replace the old unit tests
a376cb0 
Continue migration towards a behavior-driven style of testing for the REST endpoints and away from
heavy mocking.

Closes #310
jkglasbrenner pushed a commit that referenced this issue Nov 30, 2023
@lbarbMITRE @jkglasbrenner
test: add experiment integration tests that replace the old unit tests
ab3c062 
Continue migration towards a behavior-driven style of testing for the REST endpoints and away from
heavy mocking.

Closes #310
jkglasbrenner pushed a commit that referenced this issue Nov 30, 2023
@lbarbMITRE @jkglasbrenner
test: add experiment integration tests that replace the old unit tests
e67864e 
Continue migration towards a behavior-driven style of testing for the REST endpoints and away from
heavy mocking.

Closes #310
@jkglasbrenner
Copy link
Collaborator

Closed by #322

The test coverage in controller.py still isn't 100%, but that is because there are if statements that are difficult to access. This won't be an issue after the endpoint refactors are finished, since that pushes all of the if/else logic into the service layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarbMITRE lbarbMITRE

Labels
test Additions or changes to project tests
Projects
None yet
Milestone
November Milestone
Development

No branches or pull requests
3 participants
@jkglasbrenner @keithmanville @lbarbMITRE