From a661aaa168788dffb1d7dcb1c95952b4106e9b7e Mon Sep 17 00:00:00 2001
From: Keith Manville <kmanville@mitre.org>
Date: Fri, 4 Oct 2024 11:11:42 -0400
Subject: [PATCH] fix: fix issue in modifying plugins associated with an
 entrypoint

This commit fixes an issue when appending or deleting a plugin from an entrypoint. The services
were re-using EntrypointPluginFile and EntrypointParameter ORM objects when creating new Entrypoint
snapshots. This led to consistency errors in the database. The service implementations were
corrected to construct new ORM objects to attach to the new Entrypoint snapshot
---
 src/dioptra/restapi/v1/entrypoints/service.py | 23 ++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/src/dioptra/restapi/v1/entrypoints/service.py b/src/dioptra/restapi/v1/entrypoints/service.py
index b0d67d20c..8ae147566 100644
--- a/src/dioptra/restapi/v1/entrypoints/service.py
+++ b/src/dioptra/restapi/v1/entrypoints/service.py
@@ -619,7 +619,11 @@ def append(
             for plugin_file in plugin["plugin_files"]
         ]
         existing_entry_point_plugin_files = [
-            entry_point_plugin_file
+            models.EntryPointPluginFile(
+                entry_point=new_entrypoint,
+                plugin=entry_point_plugin_file.plugin,
+                plugin_file=entry_point_plugin_file.plugin_file,
+            )
             for entry_point_plugin_file in entrypoint.entry_point_plugin_files
             if entry_point_plugin_file.plugin.resource_id not in set(plugin_ids)
         ]
@@ -753,16 +757,29 @@ def delete(
             raise EntrypointPluginDoesNotExistError
 
         # create a new snapshot with the plugin removed
+        entrypoint_parameters = [
+            models.EntryPointParameter(
+                name=param.name,
+                default_value=param.default_value,
+                parameter_type=param.parameter_type,
+                parameter_number=param.parameter_number,
+            )
+            for param in entrypoint.parameters
+        ]
         new_entrypoint = models.EntryPoint(
             name=entrypoint.name,
             description=entrypoint.description,
             task_graph=entrypoint.task_graph,
-            parameters=entrypoint.parameters,
+            parameters=entrypoint_parameters,
             resource=entrypoint.resource,
             creator=current_user,
         )
         new_entrypoint.entry_point_plugin_files = [
-            entry_point_plugin_file
+            models.EntryPointPluginFile(
+                entry_point=new_entrypoint,
+                plugin=entry_point_plugin_file.plugin,
+                plugin_file=entry_point_plugin_file.plugin_file,
+            )
             for entry_point_plugin_file in entrypoint.entry_point_plugin_files
             if entry_point_plugin_file.plugin.resource_id != plugin_id
         ]