Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow @ style violations #82

Open
KeenWill opened this issue Feb 19, 2021 · 2 comments
Open

Narrow @ style violations #82

KeenWill opened this issue Feb 19, 2021 · 2 comments
Assignees

Comments

@KeenWill
Copy link
Collaborator

KeenWill commented Feb 19, 2021

Styler checker flags (list_of_set lt) @ x @ (list_of_set rt) as

Warning:
	using `@` to prepend an element to a list
You wrote:
	 [x] @ (list_of_set rt)
Consider:
	using `::` instead

This is good style though ... Let's keep the style checker from flagging uses of @ lines like this.

@KeenWill KeenWill self-assigned this Feb 19, 2021
@sweirich
Copy link

sweirich commented Feb 19, 2021

I'd prefer if the style checker did not flag [x] @ xs and tell students to rewrite as x :: xs.

I like to present inorder as (inorder rt) @ [x] @ (inorder rt) to emphasize the symmetry and connection to the other traversals

@KeenWill
Copy link
Collaborator Author

Whoops I had a typo in my comment. It's been updated to say that something of the form list @ [element] @ list is good style that we don't want the style checker to flag (which it currently does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants