From 873f0ce8a02885e8c16ed4464eb725642cf8cc09 Mon Sep 17 00:00:00 2001 From: David Date: Tue, 21 Jan 2025 17:15:44 -0500 Subject: [PATCH] fix(hr): Update HR conditions --- .../HotReload/ClientHotReloadProcessor.Agent.cs | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Agent.cs b/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Agent.cs index 4abdd9c1e048..d00c06a92920 100644 --- a/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Agent.cs +++ b/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Agent.cs @@ -90,20 +90,10 @@ private void CheckMetadataUpdatesSupport() || (!Debugger.IsAttached && !buildingInsideVisualStudio && isSkia) // Mono Debugger under VS Win already handles metadata updates - // Mono Debugger under VS Code prevents metadata based hot reload + // Mono Debugger under VS Code & Rider prevents metadata based hot reload || (!Debugger.IsAttached && !buildingInsideVisualStudio && isWasm) - - // Disabled until https://github.com/dotnet/runtime/issues/93860 is fixed - // - //|| - //( - // buildingInsideVisualStudio.Equals("true", StringComparison.OrdinalIgnoreCase) - // && ( - // // As of VS 17.8, when the debugger is not attached, mobile targets can use - // // DevServer's hotreload workspace, as visual studio does not enable it on its own. - // (!Debugger.IsAttached - // && (targetFramework.Contains("-android") || targetFramework.Contains("-ios"))))) - ; + || (!Debugger.IsAttached && !buildingInsideVisualStudio && OperatingSystem.IsAndroid()) + || (!Debugger.IsAttached && !buildingInsideVisualStudio && OperatingSystem.IsIOS()); var vsEnabled = isForcedMetadata || (buildingInsideVisualStudio && isSkia)