Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on automatic spam filter exclude #12

Open
TheAmg opened this issue Jun 13, 2024 · 0 comments
Open

Improvement on automatic spam filter exclude #12

TheAmg opened this issue Jun 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@TheAmg
Copy link
Contributor

TheAmg commented Jun 13, 2024

Describe the bug

On DirectInvoking a method that calls a 2nd method that generates enough candidates at once for it to be automatically excluded (from the same class), the filters are always set to exclude the current class. This will prevent candidates from other methods from the same class from showing up.

Example :
DirectInvokeunlogged-spring-maven-demo -> RecursionController -> getFibonacciSeries().
Candidates for getFibonacciSeries will be excluded on clicking the inlay hint above the method due to the 109 candidates from fibonacci method. (input 10). Removing the entry in excluded class manually is necessary for this candidate to show up.

https://github.com/unloggedio/intellij-java-plugin/assets/68552461/00b66be5-934b-4396-aa6b-b9ee48a24e9a

Reproduction steps

  1. Start unlogged-spring-maven-demo
  2. DirectInvoke RecursionController -> getFibonacciSeries
  3. Try to save candidate for getFibonacciSeries

Expected behavior

The spam filter should ideally only filter out only the spammy method from that class and not all the methods from that class.

Additional context

No response

@TheAmg TheAmg added the enhancement New feature or request label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant