Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure errors are logged correctly #2663

Open
3 tasks done
chronark opened this issue Nov 15, 2024 · 1 comment
Open
3 tasks done

Ensure errors are logged correctly #2663

chronark opened this issue Nov 15, 2024 · 1 comment
Labels
Bug Something isn't working Core Team

Comments

@chronark
Copy link
Collaborator

chronark commented Nov 15, 2024

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

it looks like we're not correctly capturing the error message

 if (err) {
      throw new UnkeyApiError({
        code: "INTERNAL_SERVER_ERROR",
        message: `unable to load ratelimit: ${err.message}`,
      });
    }

The resulting log doesn't have it
CleanShot 2024-11-15 at 15 27 36@2x

Steps to Reproduce

no idea

Expected behavior

log message

Other information

No response

Screenshots

No response

Version info

- OS:
- Node:
- npm:
@chronark chronark added Bug Something isn't working Needs Approval Needs approval from Unkey Core Team labels Nov 15, 2024
Copy link

linear bot commented Nov 15, 2024

@chronark chronark removed the Needs Approval Needs approval from Unkey label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Team
Projects
None yet
Development

No branches or pull requests

1 participant