Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Last used login Indicator should display only after successful login or return to login screen #2403

Open
3 tasks done
JeevaRamanathan opened this issue Oct 14, 2024 · 11 comments
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey

Comments

@JeevaRamanathan
Copy link

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

The last used indicator is displayed at the moment the the auth type (Google/Github) button is clicked

Steps to Reproduce

In SignIn screen (https://app.unkey.com/auth/sign-in)) click on either Google or GitHub login.

Expected behavior

Last used indicator should be displayed on only when coming back to login screen after successful login. https://app.formbricks.com/auth/login

Other information

No response

Screenshots

14.10.2024_11.30.54_REC.mp4

Version info

- OS:Windows
@JeevaRamanathan JeevaRamanathan added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 14, 2024
Copy link

oss-gg bot commented Oct 14, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

@naaa760
Copy link

naaa760 commented Oct 14, 2024

/assign

Copy link

oss-gg bot commented Oct 14, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

@naaa760
Copy link

naaa760 commented Oct 14, 2024

@JeevaRamanathan
would you like to assign this issue?

@harshsbhat
Copy link
Contributor

Suppose the login fails or it is aborted. It would show the last attempted login. I don't know if this is a bug. But let us wait for someone from the Unkey team to review this.

@JeevaRamanathan
Copy link
Author

@harshsbhat yes but what am addressing is different. If you could keenly on the formbricks and this unkey; the moment when the login is clicked before navigating to next screen the last used indicator is shown.


@naaa760 it's currently in "Needs approval" and i 'ant the moderator to assign; thanks!

@chronark
Copy link
Collaborator

I don't really see a problem with this
it shows the intent of what auth you want to use.

If you abort and use something else, it will update correctly

@JeevaRamanathan
Copy link
Author

JeevaRamanathan commented Oct 15, 2024

@chronark But the last used indicator should only display when returning to the login screen after a successful or unsuccessful login, not immediately upon selecting an authentication method.
Indicating the moment as "last used" might not be accurate as the current authentication process is ongoing.

Additionally, I don't see any option to abort unless the user clicks on another method while one is loading (if I understand this correctly).
For example: https://lex.page/auth, https://app.formbricks.com/auth/login (Even on a failed attempt it is indicated once the user is back to login screen)

@sanyamhbtu
Copy link

/assign

Copy link

oss-gg bot commented Oct 18, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey
Projects
None yet
Development

No branches or pull requests

5 participants