Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPIRED and DISABLED error codes do not include example JSON responses in Unkey Docs #2300

Open
3 tasks done
unrenamed opened this issue Oct 10, 2024 · 36 comments
Open
3 tasks done
Assignees
Labels

Comments

@unrenamed
Copy link
Contributor

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

Currently, the Unkey documentation provides example JSON responses for various error codes, enhancing clarity for developers. However, the EXPIRED and DISABLED error codes are the only exceptions, as they do not include example JSON responses.

Was it done intentionally? If no, see the proposed solutions in the Expected behavior.

https://www.unkey.com/docs/api-reference/errors/code/EXPIRED
https://www.unkey.com/docs/api-reference/errors/code/DISABLED

Steps to Reproduce

  1. Visit any of the error code documentation pages for EXPIRED or DISABLED.
  2. Compare the content on these pages with the corresponding pages for other error codes to identify the absence of JSON response examples.

Expected behavior

I propose one of the following solutions:

  • Include relevant example JSON responses for both the EXPIRED and DISABLED error codes for consistency.
  • Consider removing the existing JSON examples for other error codes if they are not essential.

Both approaches would contribute to a more uniform documentation structure.

Other information

No response

Screenshots

image image

Version info

- OS:
- Node:
- npm:
@unrenamed unrenamed added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 10, 2024
@2DELTA7
Copy link

2DELTA7 commented Oct 10, 2024

/assign

@unrenamed
Copy link
Contributor Author

@2DELTA7 This ticket first needs to be approved by the repo owners. The /assign command will not work without oss.gg label, fyi.

@perkinsjr perkinsjr added 🕹️ oss.gg 🕹️ 50 points and removed Needs Approval Needs approval from Unkey labels Oct 10, 2024
@perkinsjr
Copy link
Collaborator

/award 150

Copy link

oss-gg bot commented Oct 10, 2024

Awarding unrenamed: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed

@HimanshuGaur14
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @HimanshuGaur14! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Harshalingole
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@tandrimab
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@jayraj-kl
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@Vidhanvyrs
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@chronark
Copy link
Collaborator

Let's add examples everywhere, rather than removing. I think it helps to understand what we return

@HimanshuGaur14
Copy link

My system is facing a problem while im updating the issue , i won't be able to complete it please unassign me.
I'm sorry for the delay.

@DeepaPrasanna
Copy link
Contributor

My system is facing a problem while im updating the issue , i won't be able to complete it please unassign me. I'm sorry for the delay.

you can unassign yourself too. Look at the top right corner or use /unassign command

@HimanshuGaur14
Copy link

/unassign

Copy link

oss-gg bot commented Oct 12, 2024

Issue unassigned.

@joelwalice
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

Assigned to @joelwalice! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@joelwalice joelwalice removed their assignment Oct 12, 2024
@rajtejani
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

Assigned to @rajtejani! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@rajtejani
Copy link

After carefully reviewing the code it seems like the issue is not related with Docs but actually these ErrExpired and ErrDisabled response are not implemented. It can not be found on https://api.unkey.dev/openapi.json.

@chronark
Copy link
Collaborator

@rajtejani ah that might be yeah
if you add them here, it will add them to the openapi spec once deployed
https://github.com/unkeyed/unkey/blob/main/apps/api/src/pkg/errors/openapi_responses.ts

@rajtejani
Copy link

rajtejani commented Oct 14, 2024

Running pnpm fmt before commiting code throw some errors of dashboard code which is not relevant to my changes. There are more then 20+ problems highlighted by linter. What should I do?

@Taranv8
Copy link

Taranv8 commented Oct 14, 2024

/assign

Copy link

oss-gg bot commented Oct 14, 2024

This issue is already assigned to another person. Please find more issues here.

@div000-321go
Copy link

/assign

Copy link

oss-gg bot commented Oct 15, 2024

This issue is already assigned to another person. Please find more issues here.

@rajtejani rajtejani removed their assignment Oct 16, 2024
@Pk9697
Copy link

Pk9697 commented Oct 16, 2024

/assign

@oss-gg oss-gg bot assigned Pk9697 Oct 16, 2024
Copy link

oss-gg bot commented Oct 16, 2024

Assigned to @Pk9697! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 17, 2024

@Pk9697, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

2 similar comments
Copy link

oss-gg bot commented Oct 19, 2024

@Pk9697, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 21, 2024

@Pk9697, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests