From 5b3d52bc7c1e309dde2b6dd18d68558d6871dec1 Mon Sep 17 00:00:00 2001 From: chronark Date: Wed, 27 Nov 2024 18:30:11 +0100 Subject: [PATCH] feat: styling rfcs --- apps/engineering/app/docs/layout.tsx | 7 ++-- .../engineering/app/rfcs/[[...slug]]/page.tsx | 9 ++--- apps/engineering/app/rfcs/layout.tsx | 8 +++-- .../content/rfcs/0000-template.mdx | 33 +++++++++++++++++++ .../rfcs/0002-github-secret-scanning.mdx | 2 +- 5 files changed, 45 insertions(+), 14 deletions(-) create mode 100644 apps/engineering/content/rfcs/0000-template.mdx diff --git a/apps/engineering/app/docs/layout.tsx b/apps/engineering/app/docs/layout.tsx index 7a3a68fd33..72d183f004 100644 --- a/apps/engineering/app/docs/layout.tsx +++ b/apps/engineering/app/docs/layout.tsx @@ -1,7 +1,6 @@ import { source } from "@/app/source"; -import { RootToggle } from "fumadocs-ui/components/layout/root-toggle"; import { DocsLayout } from "fumadocs-ui/layouts/docs"; -import { Code, Component, Handshake, Terminal } from "lucide-react"; +import { Code, Component, Terminal } from "lucide-react"; import type { ReactNode } from "react"; import { baseOptions } from "../layout.config"; @@ -39,10 +38,10 @@ export default function Layout({ children }: { children: ReactNode }) { url: "/docs/architecture", icon: , }, - ] + ], }} > {children} - + ); } diff --git a/apps/engineering/app/rfcs/[[...slug]]/page.tsx b/apps/engineering/app/rfcs/[[...slug]]/page.tsx index 8d837b9835..6caded34cf 100644 --- a/apps/engineering/app/rfcs/[[...slug]]/page.tsx +++ b/apps/engineering/app/rfcs/[[...slug]]/page.tsx @@ -12,7 +12,6 @@ export default async function Page({ }: { params: { slug?: string[] }; }) { - const page = rfcSource.getPage(params.slug); if (!page) { @@ -25,13 +24,11 @@ export default async function Page({

RFCS -

Check the sidebar

- - ) + ); } const MDX = page.data.body; @@ -50,9 +47,9 @@ export default async function Page({ - {page.data.description} + {page.data.description} - + diff --git a/apps/engineering/app/rfcs/layout.tsx b/apps/engineering/app/rfcs/layout.tsx index 76e24baa47..2a74b754ce 100644 --- a/apps/engineering/app/rfcs/layout.tsx +++ b/apps/engineering/app/rfcs/layout.tsx @@ -5,8 +5,10 @@ import { baseOptions } from "../layout.config"; export default function Layout({ children }: { children: ReactNode }) { return ( - - {children} - +
+ + {children} + +
); } diff --git a/apps/engineering/content/rfcs/0000-template.mdx b/apps/engineering/content/rfcs/0000-template.mdx new file mode 100644 index 0000000000..00187c58dc --- /dev/null +++ b/apps/engineering/content/rfcs/0000-template.mdx @@ -0,0 +1,33 @@ +--- +title: 0000 Template +description: You may copy this as a starting point, but it's not required +date: 2024-11-25 +authors: + - Andreas Thomas + - Someone Else +--- + + +## Summary + +One paragraph explanation of the feature. + +## Motivation + +Why are we doing this? What use cases does it support? What is the expected outcome? + +## Detailed design + +This is the bulk of the RFC. Explain the design in enough detail for somebody familiar with the network to understand, and for somebody familiar with the code practices to implement. This should get into specifics and corner-cases, and include examples of how the feature is used. + +## Drawbacks + +I Why should we not do this? + +## Alternatives + +What other designs have been considered? What is the impact of not doing this? + +## Unresolved questions + +What parts of the design are still to be done? diff --git a/apps/engineering/content/rfcs/0002-github-secret-scanning.mdx b/apps/engineering/content/rfcs/0002-github-secret-scanning.mdx index 476a13d549..b0c55124f2 100644 --- a/apps/engineering/content/rfcs/0002-github-secret-scanning.mdx +++ b/apps/engineering/content/rfcs/0002-github-secret-scanning.mdx @@ -1,5 +1,5 @@ --- -title: 0002 GitHub Secret Scanning +title: 0002 Secret Scanning authors: - Dom Eccleston date: 2024-01-14