Bot should ignore draft pull requests #57
Comments
|
@sffc yes, however a PR could move from draft to final before the bot gets a chance to weigh in. So I might propose that the bot still update the status of the PR, just be a little less noisy. Also as far as noise, a bot can update prior messages instead of just appending new messages. That removes the history, but does reduce visual noise (not email noise). |
|
I find the history useful, fwiw.
What's the problem with that? All of the pushes will have happened in draft mode, no? |
|
My guess, having not researched the answer, is that the webhook probably is already running when a PR changes from Draft to Open, because the webhook is triggered on pr:changed or something like that. |
Even the history while in draft mode?
The potential problem would be if a user is allowed to merge a PR that didn't get checked by the PR checker, because it was ignored while in draft mode. |
Oh, no, not in draft mode
Yeah in that case having the main PR check comment get edited seems fine, it just shouldn't complain about force pushes. |
|
How about this as a concrete proposal: Bot ignores force pushes on draft PRs. For the other stuff we can have it edit if we want but it's not something ICU4X needs particularly. |
When a PR is in early development, the bot can be noisy. Given that the bot's primary purpose is to help with code reviews, there should be an option (or perhaps make it the default behavior) to suppress notifications if a PR is in Draft state.
CC @Manishearth
The text was updated successfully, but these errors were encountered: