Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypt4GH secrets manager #264

Open
brainstorm opened this issue Sep 12, 2024 · 2 comments
Open

Crypt4GH secrets manager #264

brainstorm opened this issue Sep 12, 2024 · 2 comments

Comments

@brainstorm
Copy link
Member

Instead of providing static paths resolving to secrets/keys for Crypt4gh, it should point to an endpoint that resolves to a key management service/server (HSM, HTTP endpoint, GitHub user.key, etc...)... like Elsa secrets provider (focusing on those that run on the server side, such as AWS Secrets Manager and just file-based for dev) /cc @andrewpatto .
@brainstorm brainstorm mentioned this issue Sep 12, 2024
Merged
@brainstorm
Copy link
Member Author

@mmalenic I believe you implemented most of this in #271 ? ... not a custom API endpoint but perhaps it's good enough for now?

@mmalenic
Copy link
Member

mmalenic commented Oct 21, 2024 •
edited
Loading

Yeah, it's probably okay for now. The Secrets Manager part is done, but it's not customizable beyond that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brainstorm @mmalenic