-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui5-tooling-transpile] Does not serve non-transpiled sources #1149
Comments
@Kyrodan normally all non-transpiled resource should be served by the UI5 tooling. Library dependencies are served in the There is no need to use a proxy or the Do you have a project to see the misbehavior? |
Thanks @petermuessig for pointing me to the right direction. Indeed it works as mentioned, if I remove all custom middlewares. My ui5.yaml looks like:
If I mount ui5 to e.g. "/resources/sapui5" (instead of "/resources") then it starts working again, but sapui5-library cannot be found by fiori-tools-preview anymore: it seems the proxied Launchpad always uses hardcoded "../resources/sap-ui-core.js" as bootstrapper-script. |
Seems to be a similar problem like in SAP/open-ux-tools#79 But the mentioned workaround SAP/open-ux-tools#79 (comment) does not work (anymore?). |
The updated workaround from SAP/open-ux-tools#79 (comment) works for me. |
Describe the bug
I have a mono-repository with an app and a library. I use transpile-middleware with success in my app using ui5-workspace.yaml. All transpilable js files get transpiled. All app modules and all dependent library modules can be successfully resolved by my consuming app.
Non-transpilable (static) resources, like manifest.json, CSS-Files etc. in dependent resources (like my library) were not served. This suits to my expectations.
Question: How can I serve these non-transpilable files?
What I tried:
Libraries are currently not supported, but fixed to make it work for libraries as well. But I cannot make transpile-middleware and this middlerware work at the same time.
Expected behavior
Serving non-transpilable ressources as-is.
Desktop (please complete the following information):
Additional context
Using fiori-tools-proxy as well - had issues getting it correctly configured with ui5-middleware-ui5, but works with transpile-middleware.
The text was updated successfully, but these errors were encountered: