From ab35dabdd9c9f088f440e7e967c8d11cdc01afca Mon Sep 17 00:00:00 2001
From: Stefan Topfstedt <Stefan.Topfstedt@ucsf.edu>
Date: Thu, 6 Jun 2024 15:06:41 -0700
Subject: [PATCH] adds test coverage for privacy provider.

---
 tests/privacy/provider_test.php | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/tests/privacy/provider_test.php b/tests/privacy/provider_test.php
index c4949b5..6664ab9 100644
--- a/tests/privacy/provider_test.php
+++ b/tests/privacy/provider_test.php
@@ -217,7 +217,7 @@ public function test_delete_data_for_all_users_in_context() {
 
         // Confirm that only user1's block data got deleted.
         $result = $DB->count_records('block_course_recent', ['userid' => $user1->id]);
-        $this->assertEmpty($result);
+        $this->assertEquals(0, $result);
         $result = $DB->count_records('block_course_recent', ['userid' => $user2->id]);
         $this->assertEquals(1, $result);
     }
@@ -248,6 +248,7 @@ public function test_delete_data_for_user() {
 
         // Create two users.
         $user1 = $generator->create_user();
+        $usercontext1 = context_user::instance($user1->id);
         $user2 = $generator->create_user();
 
         // Apply user-specific block config.
@@ -271,7 +272,7 @@ public function test_delete_data_for_user() {
         $this->assertEquals(1, $result);
 
         // Attempt to delete user1 data in user2 user context (should have no effect).
-        $approvedlist = new approved_contextlist($user2, $component, [$user1->id]);
+        $approvedlist = new approved_contextlist($user2, $component, [$usercontext1->id]);
         provider::delete_data_for_user($approvedlist);
 
         // Confirm that user data is still there.
@@ -280,8 +281,8 @@ public function test_delete_data_for_user() {
         $result = $DB->count_records('block_course_recent', ['userid' => $user2->id]);
         $this->assertEquals(1, $result);
 
-        // Delete teacher data in their own user context.
-        $approvedlist = new approved_contextlist($user1, $component, [$user1->id]);
+        // Delete user1 data in their own user context.
+        $approvedlist = new approved_contextlist($user1, $component, [$usercontext1->id]);
         provider::delete_data_for_user($approvedlist);
 
         // Confirm that only user2 user data is still there.
@@ -352,7 +353,7 @@ public function test_delete_data_for_users() {
         $this->assertEquals(1, $result);
 
         // Attempt to delete data in another user's context (should have no effect).
-        $approvedlist = new approved_userlist($usercontext1, $component, [$user1->id]);
+        $approvedlist = new approved_userlist($usercontext1, $component, [$user2->id]);
         provider::delete_data_for_users($approvedlist);
 
         // Confirm that user data is still there.
@@ -363,7 +364,7 @@ public function test_delete_data_for_users() {
         $result = $DB->count_records('block_course_recent', ['userid' => $user3->id]);
         $this->assertEquals(1, $result);
 
-        // Delete user1's data in user2's context.
+        // Delete data for user1 and user2 in the user context for user1.
         $approvedlist = new approved_userlist($usercontext1, $component, [$user1->id, $user2->id]);
         provider::delete_data_for_users($approvedlist);