Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race in pam/integration-tests #703

Open
adombeck opened this issue Dec 20, 2024 · 1 comment · May be fixed by #593
Open

Data race in pam/integration-tests #703

adombeck opened this issue Dec 20, 2024 · 1 comment · May be fixed by #593
Labels
bug Something isn't working jira

Comments

@adombeck
Copy link
Contributor

adombeck commented Dec 20, 2024 •
edited
Loading

From https://github.com/ubuntu/authd/actions/runs/12433665315/job/34715717561?pr=663:

github.com/ubuntu/authd/pam/integration-tests
TestCLIAuthenticate/Exit_if_authd_is_stopped
[...]
==================e
WARNING: DATA RACE
Read at 0x00c000366500 by goroutine 39:
github.com/charmbracelet/bubbles/cursor.(*Model).BlinkCmd.func1()
/home/runner/go/pkg/mod/github.com/charmbracelet/[email protected]/cursor/cursor.go:179 +0x184
github.com/charmbracelet/bubbletea.(*Program).
eventLoop.func1()
/home/runner/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:
428 +0xd5

Previous write at 0x00c000366500 by main goroutine:
github.com/ubuntu/authd/pam/internal/adapter.(*UIModel).Update()
/home/runner/work/authd/authd/pam/internal/adapter/model.go:365 +0x4e06
github.com/charmbracelet/bubbletea.(*Program).eventLoop()
/home/runner/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:461 +0x1349
github.com/charmbracelet/bubbletea.(*Program).Run()
/home/runner/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:595 +0x1a3b
main.(*pamModule).handleAuthRequest()
/home/runner/work/authd/authd/pam/pam.go:338 +0x32e4
main.(*pamModule).Authenticate()
/home/runner/work/authd/authd/pam/pam.go:212 +0x4bb
main.mainFunc()

I assume the issue is unrelated to the changes on the PR, because it didn't touch any code of the PAM module

Cc @3v1n0
@adombeck adombeck added jira bug Something isn't working labels Dec 20, 2024
@3v1n0
Copy link
Collaborator

3v1n0 commented Dec 21, 2024 •
edited
Loading

Yeah it was already handled in f176f2c (#593)

@adombeck adombeck linked a pull request Dec 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

maint(pam/integration-tests): Run all the tests with a shared authd when possible 3v1n0/authd
2 participants
@3v1n0 @adombeck