Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Do not duplicate isos anymore and upload -hwe ones instead #152

Merged
merged 2 commits into from
Jan 26, 2025
Merged

feat: Do not duplicate isos anymore and upload -hwe ones instead #152

merged 2 commits into from
Jan 26, 2025

Conversation

NiHaiden
Copy link
Collaborator

@NiHaiden NiHaiden commented Jan 25, 2025 •
edited by inffy
Loading

This PR removes the workflow step of renaming the HWE ISOs to Asus and Surface ones. They are the same now and do not need to be duplicated.

Website PR: NiHaiden/aurora-web#25

Closes: #134

@NiHaiden NiHaiden requested a review from inffy as a code owner January 25, 2025 15:36
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels Jan 25, 2025
inffy
inffy previously approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@inffy inffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm -Rf /asus-and-surface

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 25, 2025
@NiHaiden NiHaiden added this pull request to the merge queue Jan 26, 2025
Merged via the queue into main with commit 5f66f88 Jan 26, 2025
29 checks passed
@NiHaiden NiHaiden deleted the remove-duplicate-isos branch January 26, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inffy inffy inffy approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't upload seperate ISOs for both Asus and Surface devices
2 participants
@NiHaiden @inffy