Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the postprocessing dsl in buildtype #608

Open
yrom opened this issue Mar 23, 2018 · 4 comments
Open

Support for the postprocessing dsl in buildtype #608

yrom opened this issue Mar 23, 2018 · 4 comments

Comments

@yrom
Copy link

yrom commented Mar 23, 2018

It seems okbuck (ver 0.34.1) not recognize the postprocessing block.

Snippet in my app's build.gradle looks like:

buildTypes {
    release {
        postprocessing {
           obfuscate = true
           optimizeCode = false
           removeUnusedCode = true
           removeUnusedResources = true
           proguardFiles 'proguard-rules.pro'
        }
        signingConfig signingConfigs.release
        crunchPngs true
    }
}

Thx.

@runningcode
Copy link
Contributor

interesting. does it work fine if you move the proguardFiles out of the postProcessing block? i'm not familiar with the postProcessing block.

@yrom
Copy link
Author

yrom commented Mar 23, 2018

@runningcode ./buckw targets works fine, if i replace postprocessing block to old DSL, e.g.

buildTypes {
    release {
        ...
        proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
    }
}

@kageiit
Copy link
Contributor

kageiit commented Apr 2, 2018

Postprocessing block seems new. Okbuck does not support it yet

@kageiit
Copy link
Contributor

kageiit commented Apr 2, 2018

This dsl is incubating and can change at anytime - https://google.github.io/android-gradle-dsl/current/com.android.build.gradle.internal.dsl.BuildType.html#com.android.build.gradle.internal.dsl.BuildType:postprocessing

Do not plan to add support for this until it becomes stable

@kageiit kageiit changed the title FAILED: 0 proguard files found. Only one can be used. Support for the postprocessing dsl in buildtype Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants