Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatsReporter and Scope use deprecated Buckets interface #104

Open
gmkohler opened this issue Apr 5, 2022 · 0 comments
Open

StatsReporter and Scope use deprecated Buckets interface #104

gmkohler opened this issue Apr 5, 2022 · 0 comments

Comments

@gmkohler
Copy link

gmkohler commented Apr 5, 2022

This makes for awkward implementations of the interfaces for projects that treat warnings as errors.

/**
* Report a {@link Histogram}.
* @param name name of {@link Histogram} to report
* @param tags tags to report on
* @param buckets {@link Buckets} of the {@link Histogram}
* @param bucketLowerBound lower bound of the bucket to report
* @param bucketUpperBound upper bound of the bucket to report
* @param samples samples to report
*/
void reportHistogramValueSamples(
String name,
Map<String, String> tags,
Buckets buckets,
double bucketLowerBound,
double bucketUpperBound,
long samples
);
/**
* Report a {@link Histogram}.
* @param name name of {@link Histogram} to report
* @param tags tags to report on
* @param buckets {@link Buckets} of the {@link Histogram}
* @param bucketLowerBound lower bound of the bucket to report
* @param bucketUpperBound upper bound of the bucket to report
* @param samples samples to report
*/
void reportHistogramDurationSamples(
String name,
Map<String, String> tags,
Buckets buckets,
Duration bucketLowerBound,
Duration bucketUpperBound,
long samples
);

Histogram histogram(String name, @Nullable Buckets buckets);

/**
* @deprecated DO NOT USE
*
* Please use {@link ImmutableBuckets} instead
*/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant