Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move noMoreEvent into the code #99

Closed
eloisepeng opened this issue Feb 23, 2020 · 0 comments · Fixed by #98
Closed

move noMoreEvent into the code #99

eloisepeng opened this issue Feb 23, 2020 · 0 comments · Fixed by #98
Labels
dev type type type refactor Places we can tidy up

Comments

@eloisepeng
Copy link
Collaborator

Describe the part of the code base that needs to be cleaned up
This could include specific functions or general design choices. Include file names and line numbers.

Provide suggestions on how we can clean this up
move noMoreEvent into the code instead of JSON, since this event is mandatory, having it in json might be accidentally removed.

@eloisepeng eloisepeng added refactor Places we can tidy up dev type type type labels Feb 23, 2020
@eloisepeng eloisepeng changed the title move noMoreEvent into the code move noMoreEvent into the code Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev type type type refactor Places we can tidy up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant