Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert react-scripts version #105

Closed
rmcreyes opened this issue Mar 10, 2020 · 1 comment · Fixed by #106
Closed

Revert react-scripts version #105

rmcreyes opened this issue Mar 10, 2020 · 1 comment · Fixed by #106
Assignees
@rmcreyes
Labels
bug Something isn't working dev type type type

Comments

@rmcreyes
Copy link
Collaborator

Describe the bug
A clear and concise description of what the bug is.
The react-scripts dependency was updated unnecessarily.

Expected behavior
A clear and concise description of what you expected to happen.
Revert the update.
@rmcreyes rmcreyes added bug Something isn't working dev type type type labels Mar 10, 2020
@rmcreyes rmcreyes self-assigned this Mar 10, 2020
@rmcreyes rmcreyes mentioned this issue Mar 10, 2020
Merged
@chuck-sys
Copy link
Contributor

Because of the minigames PR, we may just close this as this does the same thing and this wasn't merged beforehand.

eloisepeng added a commit that referenced this issue Mar 14, 2020
@eloisepeng
Merge branch 'master' into rmcreyes/#105-revert-react-scripts-update
35c2366
eloisepeng added a commit that referenced this issue Mar 14, 2020
@eloisepeng
Merge pull request #106 from ubclaunchpad/rmcreyes/#105-revert-react-…
eea759f 
…scripts-update

Revert upgrade to react-scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmcreyes rmcreyes

Labels
bug Something isn't working dev type type type
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert upgrade to react-scripts ubclaunchpad/ubcsim2
2 participants
@chuck-sys @rmcreyes