Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seasonal events without the seasonal events #104

Merged
merged 5 commits into from
Mar 16, 2020

Conversation

chuck-sys
Copy link
Contributor

🚒 Pull Request

❓ Purpose

Give a brief description of your changes: Seasonal events are added (as a 30% chance in that month to use that event pool (with a configuration file)

🎟️ Ticket(s)

Closes #102
Affects #103

@chuck-sys chuck-sys requested a review from a team as a code owner March 7, 2020 23:52
"pool": [
"BoomerGregorEvent", "CuteGirlEvent", "FratPartyEvent"
],
"followUp": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why call this followUp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuz that's what it's called before. probably need to refactor to something easier to understand, such as startUp.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just called queue before wasn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

src/trackers/EventTracker.ts Outdated Show resolved Hide resolved
src/game-config.json Show resolved Hide resolved
eloisepeng
eloisepeng previously approved these changes Mar 15, 2020
@eloisepeng eloisepeng merged commit 9e072f5 into master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seasonal events setup
3 participants