-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running arbitrary Kotlin code #136
Comments
How about run(
// language=kotlin
command = """
println("Hello from action logic! (works already)")
""".trimIndent(),
_customArguments = mapOf(
"shell" to StringCustomValue("kotlin -howtorun .main.kts {0}")
)
) ? |
@Vampire it's not ideal - no compile time verification of the Kotlin code, no syntax highlighting outside of IntelliJ. But yeah, what you showed is already something, even better if #286 is done. We could also have runKotlin(
// language=kotlin
"println("Hello from action logic! (works already)")"
) where |
Maybe |
Why not just running a normal kotlin script?
Le ven. 17 juin 2022 à 20:09, Piotr Krzemiński ***@***.***> a
écrit :
… @Vampire <https://github.com/Vampire> it's not ideal - no compile time
verification of the Kotlin code, no syntax highlighting outside of
IntelliJ. But yeah, what you showed is already something, even better if
#286 <#286>
is done. We could also have
runKotlin(
// language=kotlin
"println("Hello from action logic! (works already)")"
)
where runKotlin would have shell = "kotlin -howtorun .main.kts {0}"
built-in + try to validate Kotlin code in workflow compile time. I'd go
this way as first iteration and see how it works in practice.
—
Reply to this email directly, view it on GitHub
<#136 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADQFSGFCDSVFMCWPAFPKI3VPS5NXANCNFSM5Q672EUA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Experimenting with a much simpler approach, WIP on https://github.com/typesafegithub/github-workflows-kt/tree/136-allow-putting-Kotlin-logic-in-lambda |
The experimental implementation is on its way, let's gather feedback. |
No description provided.
The text was updated successfully, but these errors were encountered: