Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review current output types #30

Open
88 tasks
Vampire opened this issue Aug 23, 2024 · 4 comments · May be fixed by #31
Open
88 tasks

Review current output types #30

Vampire opened this issue Aug 23, 2024 · 4 comments · May be fixed by #31

Comments

@Vampire
Copy link
Collaborator

Vampire commented Aug 23, 2024 •
edited
Loading

These 85 of 139 current typing files have outputs defined.
They should be verified for correct type, now that maybe we soon get typed outputs support in github-workflows-kt :-)
As changing those types is a potentially breaking change, it should best be done before the v3 release that make the Maven bindings stable and mandatory.
If they cannot be reviewed in time, maybe the outputs should be removed from the typing as you then get only the _Untyped fields and then later defining the correct type will be a backwards compatible change.

  • typings/Azure/webapps-deploy/v2/action-types.yml
  • typings/Azure/webapps-deploy/v3/action-types.yml
  • typings/DamianReeves/write-file-action/v1/action-types.yml
  • typings/EndBug/add-and-commit/v8/action-types.yml
  • typings/EndBug/add-and-commit/v9/action-types.yml
  • typings/JamesIves/github-pages-deploy-action/v4/action-types.yml
  • typings/JasonEtco/create-an-issue/v2/action-types.yml
  • typings/Wandalen/wretry.action/v3/action-types.yml
  • typings/Wandalen/wretry.action/v3/main/action-types.yml
  • typings/Wandalen/wretry.action/v3/post/action-types.yml
  • typings/Wandalen/wretry.action/v3/pre/action-types.yml
  • typings/actions-rs/toolchain/v1/action-types.yml
  • typings/actions/cache/v2/action-types.yml
  • typings/actions/cache/v3/action-types.yml
  • typings/actions/cache/v3/restore/action-types.yml
  • typings/actions/cache/v4/action-types.yml
  • typings/actions/cache/v4/restore/action-types.yml
  • typings/actions/configure-pages/v5/action-types.yml
  • typings/actions/create-release/v1/action-types.yml
  • typings/actions/deploy-pages/v4/action-types.yml
  • typings/actions/download-artifact/v4/action-types.yml
  • typings/actions/github-script/v6/action-types.yml
  • typings/actions/github-script/v7/action-types.yml
  • typings/actions/setup-dotnet/v3/action-types.yml
  • typings/actions/setup-dotnet/v4/action-types.yml
  • typings/actions/setup-go/v3/action-types.yml
  • typings/actions/setup-go/v4/action-types.yml
  • typings/actions/setup-go/v5/action-types.yml
  • typings/actions/setup-java/v2/action-types.yml
  • typings/actions/setup-java/v3/action-types.yml
  • typings/actions/setup-java/v4/action-types.yml
  • typings/actions/setup-node/v2/action-types.yml
  • typings/actions/setup-node/v3/action-types.yml
  • typings/actions/setup-node/v4/action-types.yml
  • typings/actions/setup-python/v2/action-types.yml
  • typings/actions/setup-python/v3/action-types.yml
  • typings/actions/setup-python/v4/action-types.yml
  • typings/actions/setup-python/v5/action-types.yml
  • typings/actions/stale/v5/action-types.yml
  • typings/actions/stale/v6/action-types.yml
  • typings/actions/stale/v7/action-types.yml
  • typings/actions/stale/v8/action-types.yml
  • typings/actions/stale/v9/action-types.yml
  • typings/actions/upload-artifact/v4/action-types.yml
  • typings/actions/upload-pages-artifact/v3/action-types.yml
  • typings/anothrNick/github-tag-action/v1/action-types.yml
  • typings/aws-actions/amazon-ecr-login/v1/action-types.yml
  • typings/aws-actions/amazon-ecr-login/v2/action-types.yml
  • typings/aws-actions/amazon-ecs-deploy-task-definition/v1/action-types.yml
  • typings/aws-actions/amazon-ecs-render-task-definition/v1/action-types.yml
  • typings/aws-actions/configure-aws-credentials/v1/action-types.yml
  • typings/aws-actions/configure-aws-credentials/v2/action-types.yml
  • typings/aws-actions/configure-aws-credentials/v3/action-types.yml
  • typings/aws-actions/configure-aws-credentials/v4/action-types.yml
  • typings/cycjimmy/semantic-release-action/v3/action-types.yml
  • typings/cycjimmy/semantic-release-action/v4/action-types.yml
  • typings/docker/build-push-action/v2/action-types.yml
  • typings/docker/build-push-action/v3/action-types.yml
  • typings/docker/build-push-action/v4/action-types.yml
  • typings/docker/build-push-action/v5/action-types.yml
  • typings/docker/setup-buildx-action/v1/action-types.yml
  • typings/docker/setup-buildx-action/v2/action-types.yml
  • typings/docker/setup-buildx-action/v3/action-types.yml
  • typings/elgohr/Publish-Docker-Github-Action/v4/action-types.yml
  • typings/elgohr/Publish-Docker-Github-Action/v5/action-types.yml
  • typings/gautamkrishnar/blog-post-workflow/v1/action-types.yml
  • typings/github/codeql-action/v2/analyze/action-types.yml
  • typings/github/codeql-action/v2/init/action-types.yml
  • typings/github/codeql-action/v2/upload-sarif/action-types.yml
  • typings/google-github-actions/auth/v0/action-types.yml
  • typings/google-github-actions/auth/v1/action-types.yml
  • typings/google-github-actions/auth/v2/action-types.yml
  • typings/gradle/actions/v3/setup-gradle/action-types.yml
  • typings/gradle/actions/v4/wrapper-validation/action-types.yml
  • typings/gradle/gradle-build-action/v2/action-types.yml
  • typings/gradle/gradle-build-action/v3/action-types.yml
  • typings/julia-actions/setup-julia/v1/action-types.yml
  • typings/peter-evans/create-issue-from-file/v4/action-types.yml
  • typings/peter-evans/create-pull-request/v4/action-types.yml
  • typings/peter-evans/create-pull-request/v5/action-types.yml
  • typings/peter-evans/create-pull-request/v6/action-types.yml
  • typings/repo-sync/pull-request/v2/action-types.yml
  • typings/ruby/setup-ruby/v1/action-types.yml
  • typings/softprops/action-gh-release/v1/action-types.yml
  • typings/softprops/action-gh-release/v2/action-types.yml
  • typings/stefanzweifel/git-auto-commit-action/v4/action-types.yml
  • typings/stefanzweifel/git-auto-commit-action/v5/action-types.yml
  • typings/subosito/flutter-action/v2/action-types.yml
@krzema12
Copy link
Member

@Vampire As discussed offline, I'm all for making it right!

Just one question: typings/tecolicom/actions-use-homebrew-tools/v1/action-types.yml on your list, where does it come from? Maybe you haven't contributed it to the repo?

@krzema12
Copy link
Member

BTW, my one-liner for generating the list is grep -Rl "outputs:" typings | sort, your list is already a bit outdated, but I'm going to use a fresh one when I perform this task.

@Vampire
Copy link
Collaborator Author

Vampire commented Aug 24, 2024

I did have contributed it, but you removed it again as upstream PR was accepted in time a week ago :-)

But that's is probably the only error in my list. You have to add ^ as start of your pattern or you get inputs and outputs called outputs in the result. My one-liner for the list was similar. :-)

@Vampire
Copy link
Collaborator Author

Vampire commented Aug 25, 2024

This is my one-liner to right away get the checkboxes / task list: git grep -l '^outputs:' | sed 's/^/- [ ] /' :-)

@Vampire Vampire linked a pull request Aug 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update output types and add some missig outputs typesafegithub/github-actions-typing-catalog
2 participants
@Vampire @krzema12