Regression with Option[Record] results in 1.0.0-RC6

[Jasper-M]

I experienced a regression in the latest 1.0.0-RC6. I don't yet have a fully tested self contained example though.
But I think it boils down to this code:

case class Foo(a: Int, b: String)
case class Bar(c: Int, d: Option[String])

sql"SELECT a, b, c, d FROM foo LEFT JOIN bar ON a = c".query[(Foo, Option[Bar])]

With these records in the DB:

| a | b     |
-------------
| 1 | 'abc' |

| c | d    |
------------
| 1 | NULL |

I used to get (Foo(1, "abc"), Some(Bar(1, None))) as the result of that query, and now I get (Foo(1, "abc"), None).

[jatcwang]

Thanks for the report. I believe this is a long running issue in doobie and should be fixed by #2136.

See the changes I made for the test scenario "Read should read correct columns for instances with Option (None)" in ReadSuite.scala. I believe in RC5 the behaviour works for your case but not in the general case.

I'll add more tests to verify that left joining a table with not-null and null columns are handled correctly.

[Jasper-M]

I believe in RC5 the behaviour works for your case but not in the general case.

Up until 1.0.0-RC5 I didn't notice issues with it. But I also haven't used that feature prolifically.

[arturaz]

If it helps I did solve this in doobie-typesafe https://github.com/arturaz/doobie-typesafe/blob/main/core/src/main/scala/doobie/Composite.scala#L134

[jatcwang]

@Jasper-M We've added a test case for this to verify your scenario so this shouldn't be an issue in the upcoming RC7.

If you got a bit of time, give the snapshot a try and let us know if you see anything fishy #2104 (comment). Thanks!