Manual twitterkit installation instructions are wrong

[guylando]

The instructions are wrong: https://github.com/twitter/twitter-kit-ios/wiki/Installation#install-twitter-kit-manually
The correct installation is to add TwitterKit and TwitterKitCore to embedded binaries and add TwitterKit to linked libraries.
For cordova this can be done using this code: https://github.com/guylando/twitterkit3-plugin/blob/master/plugin.xml#L61

Explanation:

1. TwitterKit.framework and TwitterCore.framework must be embedded or otherwise there is a runtime dyld missing library error
2. Must not link TwitterCore.framework or otherwise will get the runtime warnings discribed here: Class warnings "implemented in both" #91, Errors like: Class TWTRScribeService is implemented in both ... #18

[tolgahan-arikan]

thanks, this works!

[tolgahan-arikan]

Ahh, actually this didn't help with one of the errors on CI, private submodule 'TwitterCore.Private' in private module map, expected top-level module. Sorry for bothering but do you know anything about this error @guylando?

[guylando]

And this error prevents your oauth from working? My oauth works well after the fix inside cordova app (android + ios)