-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-close old issues where the reporter doesn't follow up #14889
Comments
I think I need to report you to some authority, you are creating way too many bots 😝 |
s/bots/microservices/ |
👍 |
I can dig it I think. |
Makes total sense 👍 |
Created a stub: https://github.com/cvrebert/no-carrier |
Submitted a patch to EGit-GitHub to fix the blocker: https://git.eclipse.org/r/#/c/35781/ |
Relatedly, what do y'all think of auto-locking closed issues where the last comment was N months ago? The GitHub API for issue locking doesn't exist yet, but a Supportocat said it is planned. |
@cvrebert Don't know how I feel about that yet. What threshold did you have in mind? Also, would the new microservice comment on it before locking it? |
3 months since last comment? Yes, it would post a final explanatory comment. |
Yeah, that sounds reasonable. And it would have its own GitHub account, I presume? |
I'd probably make the closer and the locker a single program+account. |
Is it wise for a bot to come through and close things without warning? Perhaps it makes an informative warning post beforehand: "This issue has been open for 83 days since last reply. If a reply is not posted within the next 7 days, this issue will be automatically closed." |
The 90-day timeframe is for auto-locking already-closed issues. Those issues have already died a natural death; we don't want to stimulate them by posting a comment. The auto-closing feature is separate and the timeline will be much shorter. And mere closing isn't permanent; we're quite willing to reopen issues if folks do end up getting back to us. |
Fantastic -- thanks for the clarification! |
@cvrebert While testing in Bootstrap is good in regards to regressions, would this mean the preferred action would be to X-Ref the old issue from a new one stating that Component XYZ has regressed to with same issue XXXX instead of re-opening an existing issue for a regression? Sorry if that didn't make sense. Basically just open a new issue for regressions or comment and reopen old ones if the issue arises again |
@kkirsche Yes. A new issue is a much better way to get our attention as maintainers, and folks sometimes incorrectly think a new problem is related to an old issue because the symptoms might be kinda similar, when in fact the underlying cause ends up being unrelated, in which case reopening would be semantically wrong. |
Does this need to be open here, or could we perhaps use another public repo to track these kind of meta things? Things like new bots, org level changes, etc. |
I am happy to report that this is now nearly done. I am mostly waiting on some fixes to an upstream library that will allow my project to have thorough unit tests for its GitHub interactions. Refs: jcabi/jcabi-github#1055, jcabi/jcabi-github#1056, jcabi/jcabi-github#1063 |
Blocked on one last PR: jcabi/jcabi-github#1068 |
(sigh) Had to bifurcate that PR, so there's still one to go: jcabi/jcabi-github#1073 |
Yay, the bot is finally ready! I hope to deploy it soon, pending discussion and final approval from the other members of the Core Team. The auto-locking feature has been punted to https://github.com/cvrebert/no-carrier/issues/3 |
Refs btford/mary-poppins#21
Basically, have a bot that periodically checks for currently-open issues have had an "awaiting reply" tag for at least N days without any subsequent posts by non-twbs-team users, and closes them with a nice explanatory comment.
The text was updated successfully, but these errors were encountered: